yumoqing/bricks
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: ResourceBrowser strip tools before clone_descriptor (avoid circular ref from buildBind event_widget)

Browse Source
This commit is contained in:
p 2026-08-13 16:01:42 +08:00 committed by yumoqing
parent 71dae6ecfe
commit 9e23fbccb9
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bricks/resourcebrowser.js
View File

@ -119,8 +119,9 @@ bricks.ResourceBrowser = class extends bricks.VBox {
tree_col.dom_element.style.minHeight = '0'; tree_col.dom_element.style.minHeight = '0';
body.add_widget(tree_col); body.add_widget(tree_col);
var tree_desc = this.clone_descriptor(this.tree_options); var tree_copy = bricks.extend({}, this.tree_options);
delete tree_desc.tools; delete tree_copy.tools;
var tree_desc = this.clone_descriptor(tree_copy);
// select-only: clicking the same node must not unselect it // select-only: clicking the same node must not unselect it
tree_desc.options = tree_desc.options || {}; tree_desc.options = tree_desc.options || {};
tree_desc.options.select_only = true; tree_desc.options.select_only = true;
@ -167,8 +168,9 @@ bricks.ResourceBrowser = class extends bricks.VBox {
return; return;
} }
var desc = this.clone_descriptor(this.browser_options); var browser_copy = bricks.extend({}, this.browser_options);
delete desc.tools; delete browser_copy.tools;
var desc = this.clone_descriptor(browser_copy);
desc.options = desc.options || {}; desc.options = desc.options || {};
desc.options.params = bricks.extend({}, desc.options.params || {}); desc.options.params = bricks.extend({}, desc.options.params || {});
if (id === null || id === undefined){ if (id === null || id === undefined){